Skip to content

Commit

Permalink
Update package maintainer
Browse files Browse the repository at this point in the history
  • Loading branch information
@bjsowa
bjsowa committed Sep 29, 2024
1 parent ea298d6 commit 3a5432b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion package.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<version>1.0.0</version>
<description>HTTP Streaming of ROS Image Topics in Multiple Formats</description>

<maintainer email="[email protected]">Russell Toris</maintainer>
<maintainer email="[email protected]">Błażej Sowa</maintainer>
<author email="[email protected]">Mitchell Wills</author>

<license>BSD</license>
Expand Down

2 comments on commit 3a5432b

@sea-bass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjsowa When you update maintainers in an open-source repo, please don't remove the original maintainers. Instead, simply add yourself. If you could re-add Russell's name to these package.xml, that would be appropriate. Thanks!

Also, please try to use pull requests for all your changes.

@bjsowa
Copy link
Collaborator Author

@bjsowa bjsowa commented on 3a5432b Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please try to use pull requests for all your changes.

I only did a couple of changes without PR to speed some things up. Right now, all of the changes are going through a pull request (the ros2 branch is protected so I don't have other option).

When you update maintainers in an open-source repo, please don't remove the original maintainers. Instead, simply add yourself. If you could re-add Russell's name to these package.xml, that would be appropriate. Thanks!

I can re-add @rctoris but I'm not sure listing people who were not involved in maintenance for over 9 years is a good idea. It just makes it harder for other people to contact active maintainers.

Please sign in to comment.