Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing parameters from the command line #120

Closed
wants to merge 1 commit into from

Conversation

lFatality
Copy link

Public API Changes

None

Description

This fix enables passing parameters to the web_video_server node via the command line or a yaml file, e.g. to change the port or address.
Currently this does not work since the parameters are not declared in the node.
To fix the issue the node option automatically_declare_parameters_from_overrides was set to true.

This then enables passing parameters to the node in ROS 2 (Foxy) like so:

ros2 run web_video_server web_video_server --ros-args -p port:=8181

or like this:

ros2 run web_video_server web_video_server --ros-args --params-file /path/to/your/params.yaml

where params.yaml:

_web_video_server:
  ros__parameters:
    port: 8181

@bjsowa
Copy link
Collaborator

bjsowa commented Oct 2, 2024

Parameters have been reworked in #154 and #156

@bjsowa bjsowa closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants