Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Src Resolver #36

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Src Resolver #36

merged 1 commit into from
Jul 18, 2018

Conversation

akrigline
Copy link
Contributor

QOL change that turns our imports from this:

import SomeComponent from '../../components/someComponent'

to this:

import SomeComponent from 'components/someComponent'

Makes use of Webpack's config.resolve to accomplish this.
Intellisense breaks normally with this configuration, unless you include a jsconfig.json telling it where the files are coming from.
Jest breaks with this configuration unless you include moduleDirectories option to tell it where the files are coming from.

@akrigline akrigline added enhancement New feature or request webpack Issue has to do with webpack config. labels Jun 21, 2018
@dfagan2
Copy link
Contributor

dfagan2 commented Jul 18, 2018

nice!!

@akrigline
Copy link
Contributor Author

Per your comment on #36 , I'm not certain that the jsconfig file here is used in anything but vsCode.

@dfagan2
Copy link
Contributor

dfagan2 commented Jul 18, 2018

i think you mean #37 ?

since there is the off chance that some other IDE looks for this file, and because its to prevent a "break" instead of add an enhancement, i'm okay with leaving it

@akrigline
Copy link
Contributor Author

Right, sorry. Yeah that makes sense. It seems like jsconfig is an intellisense thing, rather than VSCode specific.

@akrigline akrigline merged commit 7f6936a into master Jul 18, 2018
@akrigline akrigline deleted the srcResolver branch July 18, 2018 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request webpack Issue has to do with webpack config.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants