Fixed room information component #426
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good work, @Yashraj7890 . I would like to add a few points here. Ensure that hiding the scrollbar does not affect the scrollbar in the Threads menu. Also, closing the menu after clicking outside is not an appropriate behavior in this case. If it were designed with an overlay over the chat body, that would be expected behavior. However, currently, both the chat body and menu is expected and designed to work at the same time. So hiding the scrollbar is good, but the rest I feel is not appropriate in my opinion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the component's functionality to hide when clicked outside the component and also removed the unwanted scrollbars.
Fixes # (425)
Closes #425