[FEAT] Added Rocket.Chat Auth component supporting Google OAuth #183

Palanikannan1437 · 2022-09-14T11:22:11Z

Closes the Rocket.Chat Auth component supporting Google OAuth part of #182

Issue in brief

Evolution of the RC4Community platform has been happening on RC4Conferences project. In order to start the above process, Auth re-work has to be done, starting with supporting Google OAuth in Rocket.Chat Auth!

Suggested Fixes/Changes

Back-ported from RC4Conferences
Added the essential functions for login and logout via Google OAuth
Fixed adding hashmail to cookies
Added necessary env variable in .env.local.sample for hashing
Changed relevant directory and file names to match Rocket.Chat Auth Component for future support!

Demo of the above Suggested Changes

Now the user is able to login and logout into the Rocket.Chat instance with Google as the OAuth Provider!

Fixes/Changes after suggestions

Added function to resend email code 2FA
Added Resume token logic to login to Rocket.Chat via RC4Community using the Click to Chat button!
Removed Click to Chat button from UI if user is not logged in!
Fixed context of user object from auth for accessibility across necessary components

Demo of the new Changes after suggestions

Palanikannan1437 · 2022-09-14T11:25:45Z

Thanks a lot for all the guidance and support @Sing-Li and @Dnouv!!

It'd be awesome if you guys could review this and suggest changes to be made, if any😄

lgtm-com · 2022-09-14T11:27:29Z

This pull request introduces 1 alert when merging 6c5d966 into 04f9a06 - view on LGTM.com

new alerts:

1 for Clear text transmission of sensitive cookie

Sing-Li · 2022-09-14T13:12:30Z

This is awesome work @Palanikannan1437 ! Please wire up the "Click to Chat" button top right for proper behavior.

It will demonstrate to all users how to use the auxiliary data obtained from Auth. (which is a major feature of the auth component)

Sing-Li

Not a good idea to commit package-lock.json -- most of the time it will cause problem for others.

lgtm-com · 2022-09-18T15:47:35Z

This pull request introduces 1 alert when merging 4efe59b into 04f9a06 - view on LGTM.com

new alerts:

1 for Clear text transmission of sensitive cookie

Palanikannan1437 · 2022-09-18T16:18:06Z

Not a good idea to commit package-lock.json -- most of the time it will cause problem for others.

Ohh! I had no idea, thank you so much for letting me know about this! I have made made the requested changes @Sing-Li

Also, w.r.t to the given tasks...I'm still trying to understand the entire workflow of the RC4Conferences app...will come up with a PR for the same soon💪

lgtm-com · 2022-09-18T16:28:46Z

This pull request introduces 1 alert when merging d051992 into 04f9a06 - view on LGTM.com

new alerts:

1 for Clear text transmission of sensitive cookie

Sing-Li · 2022-09-18T16:53:09Z

Not a good idea to commit package-lock.json -- most of the time it will cause problem for others.

Ohh! I had no idea, thank you so much for letting me know about this! I have made made the requested changes @Sing-Li

Also, w.r.t to the given tasks...I'm still trying to understand the entire workflow of the RC4Conferences app...will come up with a PR for the same soon💪

Cool. You probably don't need to know the entire workflow to wire the click-to-chat button. That's the whole idea of being componentized - you don't need to know what other components (such as the RC4Conferences components) are doing.

app/components/auth/rc-auth-google/hooks/useRCAuth4Google.js

app/pages/api/encrypt/signRole.js

app/pages/api/encrypt/unsignCook.js

app/pages/api/encrypt/signCook.js

app/lib/conferences/eventCall.js

app/package.json

app/.env.local.sample

app/components/menubar.js

Palanikannan1437 · 2022-09-23T13:37:48Z

Not a good idea to commit package-lock.json -- most of the time it will cause problem for others.

Ohh! I had no idea, thank you so much for letting me know about this! I have made made the requested changes @Sing-Li
Also, w.r.t to the given tasks...I'm still trying to understand the entire workflow of the RC4Conferences app...will come up with a PR for the same soon💪

Cool. You probably don't need to know the entire workflow to wire the click-to-chat button. That's the whole idea of being componentized - you don't need to know what other components (such as the RC4Conferences components) are doing.

Yup that's definitely true! I got it working!! I'll send a PR asap after cleaning the code a bit!

I just wanted to know the entire workflow in order to make significant contributions in the future and to get a basic idea of how things are working as a whole😁

lgtm-com · 2022-09-25T06:17:56Z

This pull request introduces 2 alerts when merging 2ec67ff into 04f9a06 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class
1 for Clear text transmission of sensitive cookie

app/components/auth/rc-auth-google/hooks/useRCAuth4Google.js

lgtm-com · 2022-09-30T10:53:58Z

This pull request introduces 3 alerts when merging 786f260 into 04f9a06 - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class
1 for Clear text transmission of sensitive cookie

Palanikannan1437 · 2022-09-30T11:15:13Z

This is awesome work @Palanikannan1437 ! Please wire up the "Click to Chat" button top right for proper behavior.

It will demonstrate to all users how to use the auxiliary data obtained from Auth. (which is a major feature of the auth component)

Hey @Sing-Li I've added the requested changes to the Click to Chat button, now

If user is logged in, the click to chat button opens up a new R.C instance window with the user already logged into rocket chat
If user is not logged in, the button redirects to the home page of the given R.C instance

Current Issues I'm facing,

Once say the user logs in to Rocket chat via google auth, I use the authToken provided by Rocket.Chat app instance to use it as a resume token...but after using the resume token once and say if the user logs out of the Rocket.Chat app instance, the current resume token doesn't work anymore....how do I revalidate the resumetoken/accessToken?....the only way I could think of is calling the api/v1/login route again for a new authToken

Sing-Li · 2022-10-01T13:01:24Z

@Palanikannan1437 thank you.

If user is not logged in, the button redirects to the home page of the given R.C instance

Instead of redirecting, can we pop up the login dialog (as if they clicked the login button)?

Palanikannan1437 · 2022-10-01T13:03:26Z

@Palanikannan1437 thank you.

If user is not logged in, the button redirects to the home page of the given R.C instance

Instead of redirecting, can we pop up the login dialog (as if they clicked the login button)?

Ohh yeah sure, like the login modal from the login button would have to be triggered or a new similar modal from this button has to be triggered? @Sing-Li

Sing-Li · 2022-10-04T02:03:47Z

@Palanikannan1437 hope you've concluded with @Dnouv that the "click to chat" button should not be visible (as with certain other TopNav elements) if the user is logged out.

Palanikannan1437 · 2022-10-04T20:35:02Z

@Palanikannan1437 hope you've concluded with @Dnouv that the "click to chat" button should not be visible (as with certain other TopNav elements) if the user is logged out.

Ohhh okay, I'll make these changes asap then!

lgtm-com · 2022-10-05T03:35:35Z

This pull request introduces 3 alerts when merging b2d54e7 into 04f9a06 - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class
1 for Clear text transmission of sensitive cookie

Palanikannan1437 · 2022-10-05T06:34:28Z

@Sing-Li and @Dnouv could you please review the latest changes? This is how everything works now!

lgtm-com · 2022-10-05T06:43:34Z

This pull request introduces 2 alerts when merging a74e9e6 into 04f9a06 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class
1 for Clear text transmission of sensitive cookie

Sing-Li · 2022-10-06T13:16:33Z

Thanks @Palanikannan1437

…etChat#183) * added Rocket.Chat Auth component supporting Google OAuth * removed conf related hashing functions and dependencies * click to chat button functionality with google oauth added * 2fa resend method added and click to chat logic improved * hide click to chat from UI if not logged in * channel name made configurable via parameter

Palanikannan1437 mentioned this pull request Sep 14, 2022

[TODO] Create a "Watch YouTube and chat Together" component #184

Closed

Sing-Li self-requested a review September 14, 2022 15:38

Sing-Li requested changes Sep 18, 2022

View reviewed changes

added Rocket.Chat Auth component supporting Google OAuth

d051992

Palanikannan1437 force-pushed the rocketchat-auth-component branch from 4efe59b to d051992 Compare September 18, 2022 16:14

Dnouv suggested changes Sep 23, 2022

View reviewed changes

removed conf related hashing functions and dependencies

2ec67ff

Dnouv reviewed Sep 28, 2022

View reviewed changes

app/components/auth/rc-auth-google/hooks/useRCAuth4Google.js Show resolved Hide resolved

Palanikannan1437 added 2 commits September 30, 2022 13:01

click to chat button functionality with google oauth added

05e33c8

2fa resend method added and click to chat logic improved

786f260

hide click to chat from UI if not logged in

b2d54e7

channel name made configurable via parameter

a74e9e6

Palanikannan1437 marked this pull request as ready for review October 5, 2022 06:32

Palanikannan1437 changed the title ~~Added Rocket.Chat Auth component supporting Google OAuth~~ [FEAT] Added Rocket.Chat Auth component supporting Google OAuth Oct 5, 2022

Sing-Li merged commit 2635a69 into RocketChat:master Oct 6, 2022

sidmohanty11 mentioned this pull request Dec 5, 2022

Explore TOTP compatibility RocketChat/EmbeddedChat#14

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FEAT] Added Rocket.Chat Auth component supporting Google OAuth #183

[FEAT] Added Rocket.Chat Auth component supporting Google OAuth #183

Palanikannan1437 commented Sep 14, 2022 •

edited

Loading

Palanikannan1437 commented Sep 14, 2022

lgtm-com bot commented Sep 14, 2022

Sing-Li commented Sep 14, 2022

Sing-Li left a comment

lgtm-com bot commented Sep 18, 2022

Palanikannan1437 commented Sep 18, 2022

lgtm-com bot commented Sep 18, 2022

Sing-Li commented Sep 18, 2022

Palanikannan1437 commented Sep 23, 2022

lgtm-com bot commented Sep 25, 2022

lgtm-com bot commented Sep 30, 2022

Palanikannan1437 commented Sep 30, 2022

Sing-Li commented Oct 1, 2022

Palanikannan1437 commented Oct 1, 2022 •

edited

Loading

Sing-Li commented Oct 4, 2022 •

edited

Loading

Palanikannan1437 commented Oct 4, 2022

lgtm-com bot commented Oct 5, 2022

Palanikannan1437 commented Oct 5, 2022

lgtm-com bot commented Oct 5, 2022

Sing-Li commented Oct 6, 2022

[FEAT] Added Rocket.Chat Auth component supporting Google OAuth #183

[FEAT] Added Rocket.Chat Auth component supporting Google OAuth #183

Conversation

Palanikannan1437 commented Sep 14, 2022 • edited Loading

Issue in brief

Suggested Fixes/Changes

Demo of the above Suggested Changes

Fixes/Changes after suggestions

Demo of the new Changes after suggestions

Palanikannan1437 commented Sep 14, 2022

lgtm-com bot commented Sep 14, 2022

Sing-Li commented Sep 14, 2022

Sing-Li left a comment

Choose a reason for hiding this comment

lgtm-com bot commented Sep 18, 2022

Palanikannan1437 commented Sep 18, 2022

lgtm-com bot commented Sep 18, 2022

Sing-Li commented Sep 18, 2022

Palanikannan1437 commented Sep 23, 2022

lgtm-com bot commented Sep 25, 2022

lgtm-com bot commented Sep 30, 2022

Palanikannan1437 commented Sep 30, 2022

Sing-Li commented Oct 1, 2022

Palanikannan1437 commented Oct 1, 2022 • edited Loading

Sing-Li commented Oct 4, 2022 • edited Loading

Palanikannan1437 commented Oct 4, 2022

lgtm-com bot commented Oct 5, 2022

Palanikannan1437 commented Oct 5, 2022

lgtm-com bot commented Oct 5, 2022

Sing-Li commented Oct 6, 2022

Palanikannan1437 commented Sep 14, 2022 •

edited

Loading

Palanikannan1437 commented Oct 1, 2022 •

edited

Loading

Sing-Li commented Oct 4, 2022 •

edited

Loading