Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Replies don't render images #2564

Closed
wants to merge 7 commits into from
Closed

[FIX] Replies don't render images #2564

wants to merge 7 commits into from

Conversation

vitorl-s
Copy link
Contributor

@vitorl-s vitorl-s commented Oct 15, 2020 •
edited
Loading

Signed-off-by: Vitor Leal [email protected]

Proposed changes

The reply of an image renders a full image in the reply box

Issue(s)

#704

How to test or reproduce

Reply any message

Screenshots

Screen Shot 2020-11-12 at 15 55 55

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

@vitorl-s vitorl-s marked this pull request as draft October 15, 2020 18:36
@lgtm-com
Copy link

lgtm-com bot commented Oct 15, 2020

This pull request introduces 1 alert when merging ef3a88b into b847428 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@CLAassistant
Copy link

CLAassistant commented Oct 22, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vitorl-s vitorl-s marked this pull request as ready for review October 29, 2020 18:26
@vitorl-s vitorl-s changed the title [WIP] - Replies don't render images [IMPROVEMENT] - Replies don't render images Oct 29, 2020
@djorkaeffalexandre djorkaeffalexandre changed the title [IMPROVEMENT] - Replies don't render images [FIX] Replies don't render images Oct 29, 2020
@djorkaeffalexandre
Copy link
Collaborator

Make sure of add screenshots of your changes on PR's like this where screenshots can be applied.

@gerzonc
Copy link
Contributor

gerzonc commented Jul 15, 2021

It seems to be working fine, can you resolve conflicts? Thanks for your contribution!

@gerzonc gerzonc mentioned this pull request Sep 21, 2021
Closed
10 tasks
@gerzonc gerzonc mentioned this pull request Mar 14, 2022
Merged
10 tasks
@diegolmello
Copy link
Member

Closing in favor of #3883

@diegolmello diegolmello deleted the new.reply.image branch March 15, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djorkaeffalexandre djorkaeffalexandre Awaiting requested review from djorkaeffalexandre

Assignees
No one assigned
Labels
🛠 fix 🚨 needs changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vitorl-s @CLAassistant @djorkaeffalexandre @gerzonc @diegolmello @frclba