Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(iOS): share extension not working for screenshots #6103

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(iOS): share extension not working for screenshots #6103

wants to merge 1 commit into from

Conversation

diegolmello
Copy link
Member

@diegolmello diegolmello commented Jan 23, 2025 •
edited
Loading

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

ScreenRecording_01-24-2025.14-40-53_1.MP4

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

NATIVE-764

@diegolmello diegolmello marked this pull request as ready for review January 24, 2025 17:43
OtavioStasiak
OtavioStasiak approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@OtavioStasiak OtavioStasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.
Tested on iPhone 13 (iOS 17.6.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OtavioStasiak OtavioStasiak OtavioStasiak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diegolmello @OtavioStasiak