feat: Display total number and room unread messages in room title #32304
+27
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8594c56 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
MichalFoksa
force-pushed
the
feature/develop/display-total-unread-and-room-unread-in-room-title
branch
from
57a049d to
3431f94
Compare
Text "xyz unread messages" in document title replaced by room title format [total unread] (room unread) Room Name Where:
[total unread] - is total number of unread messages - hidden when equal to zero
(room unread) - is number of room unread messages - hidden when equal to zero
MichalFoksa
force-pushed
the
feature/develop/display-total-unread-and-room-unread-in-room-title
branch
from
1a287ba to
8594c56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLTR
PR replaces room title from:
to:
PR changes room title to:
Format:
Examples:
[10] (5) Mark Watney - workspace name[10] general - workspace name- AFAIK channels do not have number of unread messages, so room unread not showgeneral - workspace name- no unread messagesNote: 32 is total number of unread, 17 "Johny Smith" room unread, 15 "Mark Watney" room unread
Issue(s)
RocketChat/feature-requests#885
Steps to test or reproduce
Further comments