-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n: change text on enable message history setting description #32662
base: develop
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32662 +/- ##
===========================================
+ Coverage 56.71% 56.74% +0.02%
===========================================
Files 2498 2498
Lines 55385 55385
Branches 11455 11455
===========================================
+ Hits 31412 31428 +16
+ Misses 21267 21256 -11
+ Partials 2706 2701 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we delete the translations in all other languages so that they are re-generated?
btw I believe we should mark this PR as i18n
instead of chore
🤔
Change text on Enable Message History description since it was telling the user that this setting enables the endpoint
/api/v1/im.history.others
and its/api/v1/im.messages.others
.Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/SUP-604
Steps to test or reproduce
Further comments