-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve stats cronjob scheduling #33311
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 33c1a83 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33311 +/- ##
========================================
Coverage 75.18% 75.18%
========================================
Files 495 495
Lines 21600 21600
Branches 5362 5362
========================================
Hits 16241 16241
Misses 4717 4717
Partials 642 642
Flags with carried forward coverage won't be shown. Click here to find out more.
|
5406e47
to
65c816c
Compare
65c816c
to
78bda3d
Compare
Proposed changes (including videos or screenshots)
Since multiple instances can be spun up at different times, it means multiple cronjobs could be scheduled to run at different times, each one of them would collect ALL statistics data once again and send it back. I'm changing to check whether the latest statistics data generated was sent in the last 24h and only generate new data if that was not the case.
Issue(s)
OPI-42
Steps to test or reproduce
Further comments