Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused setUserActiveStatus client meteor method #33818

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Oct 28, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

ARCH-1343

Copy link
Contributor

dionisio-bot bot commented Oct 28, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 28, 2024

🦋 Changeset detected

Latest commit: 00c6e6b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yash-rajpal yash-rajpal marked this pull request as ready for review October 28, 2024 22:23
@yash-rajpal yash-rajpal requested a review from a team as a code owner October 28, 2024 22:23
Copy link
Contributor

github-actions bot commented Oct 28, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33818/
on branch gh-pages at 2024-10-29 20:59 UTC

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.57%. Comparing base (5c428df) to head (00c6e6b).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33818   +/-   ##
========================================
  Coverage    75.57%   75.57%           
========================================
  Files          493      493           
  Lines        21577    21577           
  Branches      5376     5376           
========================================
  Hits         16306    16306           
  Misses        4631     4631           
  Partials       640      640           
Flag Coverage Δ
unit 75.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan added this to the 7.1.0 milestone Oct 29, 2024
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Oct 29, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 29, 2024
@kodiakhq kodiakhq bot merged commit d1e8497 into develop Oct 29, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the chore/remove-setUserActiveStatus-method branch October 29, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants