-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Disallow updating closing properties of livechat rooms via Apps Engine #34897
base: develop
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34897 +/- ##
========================================
Coverage 59.13% 59.13%
========================================
Files 2819 2819
Lines 67957 67957
Branches 15138 15138
========================================
Hits 40188 40188
Misses 24935 24935
Partials 2834 2834
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, even though I'm not a backend guy 😬
fb243b3
to
7549e0f
Compare
Proposed changes (including videos or screenshots)
This change removes the capability of apps of changing some omnichannel props by directly modifying the Updater for the room. Updates were done in an unsafe way, that allowed apps to leave rooms in a bad state.
Issue(s)
Steps to test or reproduce
Further comments