Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Disallow updating closing properties of livechat rooms via Apps Engine #34897

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Jan 6, 2025

Proposed changes (including videos or screenshots)

This change removes the capability of apps of changing some omnichannel props by directly modifying the Updater for the room. Updates were done in an unsafe way, that allowed apps to leave rooms in a bad state.

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jan 6, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 6, 2025

⚠️ No Changeset found

Latest commit: 7549e0f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 6, 2025

PR Preview Action v1.5.0
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34897/
on branch gh-pages at 2025-01-09 21:25 UTC

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.13%. Comparing base (4aa95b6) to head (7549e0f).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34897   +/-   ##
========================================
  Coverage    59.13%   59.13%           
========================================
  Files         2819     2819           
  Lines        67957    67957           
  Branches     15138    15138           
========================================
  Hits         40188    40188           
  Misses       24935    24935           
  Partials      2834     2834           
Flag Coverage Δ
unit 74.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman added this to the 7.3.0 milestone Jan 7, 2025
@KevLehman KevLehman marked this pull request as ready for review January 7, 2025 16:11
@KevLehman KevLehman requested review from a team as code owners January 7, 2025 16:11
yash-rajpal
yash-rajpal previously approved these changes Jan 7, 2025
Copy link
Member

@yash-rajpal yash-rajpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, even though I'm not a backend guy 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants