-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: chat.update
allows to set message as empty string
#34934
base: develop
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: b235e66 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34934 +/- ##
========================================
Coverage 59.13% 59.13%
========================================
Files 2819 2819
Lines 67957 67957
Branches 15138 15138
========================================
Hits 40188 40188
Misses 24935 24935
Partials 2834 2834
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
chat.update
allowed to pass an emptytext
field. This caused the UI to render an empty message.Now, this is removed and API will throw an error. On UI, we don't allow this and we ask the user if the message should be deleted instead.
Issue(s)
https://rocketchat.atlassian.net/browse/CORE-603
Steps to test or reproduce
Further comments