Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fuselage): SidebarV2 styles #1516

Merged
merged 2 commits into from
Dec 20, 2024
Merged

fix(fuselage): SidebarV2 styles #1516

merged 2 commits into from
Dec 20, 2024

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Dec 19, 2024

Proposed changes (including videos or screenshots)

  • add calc to the sidebar-v2-collapse-group padding - SIDE-220
  • change SidebarV2Footer height to min-height

Issue(s)

Further comments

Copy link

changeset-bot bot commented Dec 19, 2024

🦋 Changeset detected

Latest commit: 65c878d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rocket.chat/fuselage Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@juliajforesti juliajforesti marked this pull request as ready for review December 19, 2024 19:15
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@juliajforesti juliajforesti merged commit deac02f into main Dec 20, 2024
6 checks passed
@juliajforesti juliajforesti deleted the fix/sidebar-v2-styles branch December 20, 2024 17:49
@github-actions github-actions bot mentioned this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants