-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Node design #698
Merged
Merged
Improve Node design #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- no background - more space efficient - consitent height of rows - slightly smaller previews - move Manage button next to filter and Add Nodes button to the bottom
- Enables the dotted grid on the GraphEdit - Moves the UndoRedoLabel into the StatusBar for now
If the Preview 2D (1) preview is locked, it will now not indicate ports on other nodes as previewed, that aren't actually being previewed.
Makes them smaller if possible and have a consistent size.
Added a minimum 2 pixel dragging (otherwise goes to editing), to avoid unintentional mouse movements blocking the click to edit.
Adds a slight outline and some better content margins
Changes the OptionButton (And SizeOptionButton) a bit: - better popup background - Allow Ctrl+Scroll to cycle values
Works on FloatEdit, OptionEdit and ColorButtonEdit.
This should make the margins on the left more consistent. This also fixes minimum size of items.
Creates a brand new GradientEdit with a more complex popup. Mostly recreates the old feature-set but has some additions: - New design for the cursors - Point offset can be set from a FloatEdit - The popup allows cylcing through the active cursors - Gradients with Alpha parts are displayed better - Ctrl+C and Ctrl+V will copy and paste colors from cursors - Dragging a color onto a gradient will show a preview cursor - Dragging a color onto a cursor will preview that color - The popup can be pinned, making it stay even when something outside is clicked. This allows dragging colors or gradients even into the popup or moving the graph view around. - The gradient can be copied and pasted with Ctrl+C and Ctrl+V. Main UI/UX improvements: - Make it clear how to open the popup (previously something you could only stumble upon) - Remove the interpolation dropdown from the gradient Edit (only in the popup now) to remove visual clutter. - Allow editing the offset directly, remove offset label. - Better display Gradients with transparency.
This minimum size was previously ensured because empty labels were added to all the rows. This messed up a bunch of nodes that have lot's of ports with no settings or labels.
Snapping (activated by pressing CTRL when dragging) now snaps to more useful increments based on the range of possible values of the field.
This is an attempt at fixing the graph not fully loading sometimes.
I had increased the hotzone so much, that the small reroute node wasn't even grabbable anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #697.