New theme icons #712
Merged
New theme icons #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds in an SVG icon sheet. This allows having color-changing icons and possibly having scalable icons in the future as well.
This required changing the icons in some places. We also don't want to manually reference the icon-sheet in scenes, but instead always use the theme (add the icon to the theme, e.g. the MM_Icons type) then assign them in code with `get_theme_icon("settings", "MM_Icons")`. In some cases we might have to update this on theme changes listening to NOTIFICATION_THEME_CHANGED.
Jowan-Spooner
force-pushed
the
new_icons
branch
from
e722836 to
34cd032
Compare
Also adds a few more icons.
We now have a default.tres theme and both default dark and default light are using the enhanced theme system. This makes them behave more similar. The default is still using the same base colors as dark, this could be changed in the future, probably when we want to expose the colors to the users.
Already includes a bunch of icons that aren't actually implemented yet (e.g. painting icons) for a follow up PR that tries to remove all final icon sheets in favor of the new one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #710, showing how svg icons could help with icons. There is a bunch of icons not yet converted though.
This already removes the two light and dark icon folders. To do so some icons have been replaced already. This is done by adding the icons to the theme, then adding through code (e.g. `get_theme_icon("settings", "MM_Icons").
This is basically a smaller variant of #708, only including the svg icon set and adding it in in a few places.
Some places with new icons (and properly colored icons on light themes):
Dark Theme after:
Light Theme before:
Light Theme after: