Would it be possible to add an inverted mode?

[brian6932]

It being inverted from vim by default slightly catches me off guard whenever I use this, but I really like the addon. I know I can install this manually and just flip j and k (which I have done), but would it be possible to have a toggle for this?

[RogueArt]

Huh, in the version I'm using, it matches Vim-style bindings, but in the repository code, it's flipped. I'll update it to be Vim-style to be default since that's convention and I definitely don't want to break away from that. Thanks for pointing this out!

[RogueArt]

Done, just inverted the keybinds and tested it on my end. Feel free to reopen the issue if it doesn't work or if you have any more suggestions!

[brian6932]

@RogueArt Well I tried to swap the same thing on my end locally and installed it, but it seems to scroll as opposed to go to next item, I think the setFocus function may need to be edited as well? 🤔 Not sure why it happened tho, also the AMO version has the same inverted scroll, so a new release might be necessary.

[RogueArt]

That's strange that it seems to scroll on yours, mine jumps between the next and previous item on the latest versions of Firefox and Chrome.

On the bright side, I made a new release on Firefox inverting the keybind as well as several bug fixes with one on the setFocus function. You could try reinstalling the latest version of the plugin (0.2.2) and see if the scrolling issue is fixed on your end.

I'm back to working on this extension now, so I'll keep this issue open as I want to let users set their own keybinds anyways.

[brian6932]

@RogueArt I recorded this bug, however, I am unsure of whether I should post it in this issue or create a new one, which is preferable? It occurs both in the new releases, and when I web-ext build it from the repo.

[RogueArt]

Feel free to create a new issue for it. Thanks for finding it and taking the time to report it!