🐛 fixing issue when disconnecting from mysql

Rohland · Nov 6, 2023 · 6c62c85 · 6c62c85
1 parent b9d2690
commit 6c62c85
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "barky",
-  "version": "1.0.47",
+  "version": "1.0.48",
   "description": "A simple cloud services watchdog with digest notification support & no external dependencies",
   "homepage": "https://github.com/Rohland/barky#readme",
   "main": "dist/cli.js",

diff --git a/src/evaluators/mysql.ts b/src/evaluators/mysql.ts
@@ -38,7 +38,7 @@ export class MySqlEvaluator extends BaseEvaluator {
                 apps
             };
         } finally {
-            disposeConnections();
+            await disposeConnections();
         }
     }
 
@@ -193,14 +193,8 @@ export async function getConnection(app): Promise<mysql.Connection> {
     return connection;
 }
 
-export function disposeConnections() {
-    connections.forEach(x => {
-        try {
-            x.destroy();
-        } catch {
-            // no-op
-        }
-    });
+export async function disposeConnections() {
+    await Promise.allSettled(connections.map(x => x.end()));
     connections = [];
 }