Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with text decoration #58

Open
PersianBrat opened this issue Jun 9, 2023 · 2 comments
Open

Issue with text decoration #58

PersianBrat opened this issue Jun 9, 2023 · 2 comments

Comments

@PersianBrat
Copy link
Contributor

Taking <span style="text-decoration: line-through;">text</span> as the old string and text as the new, I get the following as the result:

<span style="text-decoration: line-through;">text</span>

Which is the same as the old text and doesn't show the difference.
So, I think it should actually be like the following:

<span style="text-decoration: line-through;"><del class='diffmod'>text</del></span><ins class='diffmod'>text</ins>
@PersianBrat
Copy link
Contributor Author

I've noticed adding/removing tags like <b> also don't add <del> to the diff result. But it adds <ins> tag.
So, the same thing can happen for <span> tag I suppose.

@PersianBrat
Copy link
Contributor Author

I did some changes to make the behaviour the same for <span> tag: #59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant