Issue with text decoration #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #58 |
|
@PersianBrat thanks for the PR. Just made a few changes and added a few more tests. Let me know if this is still working for you and I'll merge in and push out a new release. |
|
Everything looks fine on my side as well and tests all passed. Thanks @Rohland |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added 2 more test cases that I felt are likely to fail over the development.
One of them actually represents the issue that I'm fixing.
I also wasn't able to run tests locally. It turned out there's an issue with
NUnit3TestAdapternuget package. So I had to update it too.