Skip to content

Commit

Permalink
[OP#162] Use the correct z index for the sidebar (#234)
Browse files Browse the repository at this point in the history
This PR updates the sidebar to use the correct Z Index. It also renames the drawer token to be sidebar specific.
  • Loading branch information
Jeremy-Walton authored Dec 14, 2024
1 parent e5cd64f commit a17cf16
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/addons/panel.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
--op-panel-width: 40%;

position: absolute;
z-index: var(--op-z-index-drawer);
z-index: var(--op-z-index-sidebar);
right: calc(-1 * var(--op-panel-width)); // this pushes the panel off the sceen to the right
width: var(--op-panel-width);
height: 100vh;
Expand Down
1 change: 1 addition & 0 deletions src/components/sidebar.scss
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@
--__op-sidebar-width: var(--_op-sidebar-drawer-width);
--__op-sidebar-brand-width: var(--_op-sidebar-drawer-brand-width);

z-index: var(--op-z-index-sidebar);
display: flex;
width: var(--__op-sidebar-width);
min-width: var(--__op-sidebar-width);
Expand Down
2 changes: 1 addition & 1 deletion src/core/tokens/base_tokens.scss
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ $breakpoint-x-large: 1440px; // medium laptop
*/
--op-z-index-header: 500;
--op-z-index-footer: 500;
--op-z-index-drawer: 700;
--op-z-index-sidebar: 700;
--op-z-index-dialog: 800;
--op-z-index-dialog-backdrop: 801;
--op-z-index-dialog-content: 802;
Expand Down

0 comments on commit a17cf16

Please sign in to comment.