Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OP-145] --op-border-color rename #212

Conversation

Jeremy-Walton
Copy link
Member

@Jeremy-Walton Jeremy-Walton commented Feb 2, 2024

Task

Fixes OP-145

Why?

The border color token did not match the pattern of other colors. This provides consistency

What Changed

  • Rename --op-border-color to --op-color-border

Sanity Check

  • Have you updated any usage of changed tokens?
  • Have you updated the docs with any component changes?
  • [ ] Have you updated the dependency graph with any component changes?
  • Have you run linters?
  • Have you run prettier?
  • Have you tried building the css?
  • Have you tried building storybook?
  • [ ] Do you need to update the package version?

Screenshots

Screenshot 2024-02-02 at 3 03 14 PM

@Jeremy-Walton Jeremy-Walton added Cleanup Clean up styles Breaking Change This will cause problems so be sure to indicate that in the release notes Base Tokens Changes to the base tokens labels Feb 2, 2024
@Jeremy-Walton Jeremy-Walton added this to the v1.0.0 Release milestone Feb 2, 2024
@Jeremy-Walton Jeremy-Walton self-assigned this Feb 2, 2024
@Jeremy-Walton Jeremy-Walton merged commit d6340bf into main Feb 7, 2024
1 check passed
@Jeremy-Walton Jeremy-Walton deleted the op-145-border-color-var-needs-to-be-renamed-to-match-op-color branch February 7, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Base Tokens Changes to the base tokens Breaking Change This will cause problems so be sure to indicate that in the release notes Cleanup Clean up styles
Development

Successfully merging this pull request may close these issues.

2 participants