Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix href Link on Avatar Component #238

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

dominicmacaulay
Copy link
Contributor

@dominicmacaulay dominicmacaulay commented Nov 12, 2024

Why?

The current href link on the Avatar component is components-avatar--docs and the actual path is content-components-avatar--docs. The breaking difference being that content is missing.

What Changed

What changed in this PR?

  • Corrected the href link

Sanity Check

  • [ ] Have you updated any usage of changed tokens?
  • Have you updated the docs with any component changes?
  • [ ] Have you updated the dependency graph with any component changes?
  • Have you run linters?
  • Have you run prettier?
  • Have you tried building the css?
  • Have you tried building storybook?
  • [ ] Do you need to update the package version?

@Jeremy-Walton Jeremy-Walton added bug Something isn't working documentation Improvements or additions to documentation labels Nov 12, 2024
@dominicmacaulay dominicmacaulay merged commit 776ad58 into main Nov 12, 2024
1 check passed
@dominicmacaulay dominicmacaulay deleted the djm-fix-avatar-href branch November 12, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Development

Successfully merging this pull request may close these issues.

2 participants