Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMD-358 optics documentation fixes (GH-239) #239

Merged
merged 5 commits into from
Nov 21, 2024

Conversation

yawnybear
Copy link
Contributor

@yawnybear yawnybear commented Nov 18, 2024

Task

RMD-358

Why?

Our current documentation for Optics has some refinements and fixes that could be made to help make it feel more consistent throughout. This includes using consistent capital case, resolving some typos, rephrasing some sentences to make it more clear to readers, and update links to external sites.

What Changed

What changed in this PR?

  • Use consistent capital case.
  • Resolve typos.
  • Rephrase sentences.
  • Update link and title to external site.

Sanity Check

  • [ ] Have you updated any usage of changed tokens?
  • [ ] Have you updated the docs with any component changes?
  • [ ] Have you updated the dependency graph with any component changes?
  • Have you run linters?
  • Have you run prettier?
  • Have you tried building the css?
  • Have you tried building storybook?
  • [ ] Do you need to update the package version?

Copy link
Member

@Jeremy-Walton Jeremy-Walton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but looks good

src/core/tokens/dark_mode_tokens.scss Outdated Show resolved Hide resolved
@yawnybear yawnybear changed the title optics documentation fixes RMD-358 optics documentation fixes (GH-239) Nov 21, 2024
Copy link

linear bot commented Nov 21, 2024

@yawnybear yawnybear merged commit e4976e1 into main Nov 21, 2024
1 check passed
@yawnybear yawnybear deleted the optics-documentation-fixes branch November 21, 2024 18:55
@Jeremy-Walton Jeremy-Walton added the documentation Improvements or additions to documentation label Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Development

Successfully merging this pull request may close these issues.

2 participants