Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OP#169] Variable Font Instructions #247

Merged
merged 2 commits into from
Dec 16, 2024
Merged

[OP#169] Variable Font Instructions #247

merged 2 commits into from
Dec 16, 2024

Conversation

Jeremy-Walton
Copy link
Member

Why?

Improving the documentation and adding instructions on how to use variable fonts.

What Changed

  • Add instructions for using variable fonts and point to google fonts

Sanity Check

  • [ ] Have you updated any usage of changed tokens?
  • Have you updated the docs with any component changes?
  • [ ] Have you updated the dependency graph with any component changes?
  • Have you run linters?
  • Have you run prettier?
  • Have you tried building the css?
  • Have you tried building storybook?
  • Do you need to update the package version?

Screenshots

Screenshot 2024-12-14 at 6 22 24 PM Screenshot 2024-12-14 at 6 22 27 PM

@Jeremy-Walton Jeremy-Walton added the documentation Improvements or additions to documentation label Dec 14, 2024
@Jeremy-Walton Jeremy-Walton self-assigned this Dec 14, 2024
@linear Linear
Copy link

linear bot commented Dec 14, 2024

OP-169 Variable Font Instructions

scriswell
scriswell approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@scriswell scriswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jeremy-Walton Approved with one suggestion.

src/stories/Tokens/Typography/FontFamily.mdx Outdated Show resolved Hide resolved
@Jeremy-Walton Jeremy-Walton merged commit a72e3e3 into main Dec 16, 2024
1 check passed
@Jeremy-Walton Jeremy-Walton deleted the op-169-variable-font-instructions branch December 16, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scriswell scriswell scriswell approved these changes

Assignees

@Jeremy-Walton Jeremy-Walton

Labels
documentation Improvements or additions to documentation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jeremy-Walton @scriswell