Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OP-189 Refactor Table #258

Merged
merged 5 commits into from
Jan 30, 2025
Merged

OP-189 Refactor Table #258

merged 5 commits into from
Jan 30, 2025

Conversation

dominicmacaulay
Copy link
Contributor

@dominicmacaulay dominicmacaulay commented Jan 30, 2025

Why?

With the move toward plain css, the Table styling needs to be converted to CSS with a strict adherence to the BEM structure.

What Changed

What changed in this PR?

  • Convert table.scss to table.css using BEM
  • Update the table builder to use the new modifier system
  • Update the docs to reflect this change

Sanity Check

  • [ ] Have you updated any usage of changed tokens?
  • Have you updated the docs with any component changes?
  • [ ] Have you updated the dependency graph with any component changes?
  • Have you run linters?
  • Have you run prettier?
  • Have you tried building the css?
  • Have you tried building storybook?
  • Do you need to update the package version?

@dominicmacaulay dominicmacaulay added Breaking Change This will cause problems so be sure to indicate that in the release notes Components Changes to a component labels Jan 30, 2025
@dominicmacaulay dominicmacaulay self-assigned this Jan 30, 2025
Copy link

linear bot commented Jan 30, 2025

OP-189 Refactor Table

@dominicmacaulay dominicmacaulay force-pushed the op-189-refactor-table branch 2 times, most recently from f2ab6fc to 5dbce71 Compare January 30, 2025 16:45
@Jeremy-Walton Jeremy-Walton merged commit 77ef759 into main Jan 30, 2025
1 check passed
@Jeremy-Walton Jeremy-Walton deleted the op-189-refactor-table branch January 30, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change This will cause problems so be sure to indicate that in the release notes Components Changes to a component
Development

Successfully merging this pull request may close these issues.

2 participants