Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OP-179 Refactor Form #262

Merged
merged 8 commits into from
Jan 30, 2025
Merged

OP-179 Refactor Form #262

merged 8 commits into from
Jan 30, 2025

Conversation

dominicmacaulay
Copy link
Contributor

@dominicmacaulay dominicmacaulay commented Jan 30, 2025

Why?

With the move towards pure css, the setup of forms needed to change.

What Changed

What changed in this PR?

  • Convert form.scss to form.css using BEM
  • Update the form docs

Sanity Check

  • [ ] Have you updated any usage of changed tokens?
  • Have you updated the docs with any component changes?
  • [ ] Have you updated the dependency graph with any component changes?
  • Have you run linters?
  • Have you run prettier?
  • Have you tried building the css?
  • Have you tried building storybook?
  • Do you need to update the package version?

Copy link

linear bot commented Jan 30, 2025

OP-179 Refactor Form

@dominicmacaulay dominicmacaulay self-assigned this Jan 30, 2025
@dominicmacaulay dominicmacaulay added Breaking Change This will cause problems so be sure to indicate that in the release notes Components Changes to a component labels Jan 30, 2025
@Jeremy-Walton Jeremy-Walton merged commit 3599538 into main Jan 30, 2025
1 check passed
@Jeremy-Walton Jeremy-Walton deleted the op-179-refactor-form branch January 30, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change This will cause problems so be sure to indicate that in the release notes Components Changes to a component
Development

Successfully merging this pull request may close these issues.

2 participants