Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCC-47] Tokens #263

Merged
merged 10 commits into from
Jan 31, 2025
Merged

[CCC-47] Tokens #263

merged 10 commits into from
Jan 31, 2025

Conversation

Jeremy-Walton
Copy link
Member

@Jeremy-Walton Jeremy-Walton commented Jan 31, 2025

Why?

With the move towards pure css, our tokens needed to be updated to no longer use mixins. As part of this, we are also taking advantage of the new light-dark() https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/light-dark function to simplify our dark mode overrides and allow for component specific light and dark mode.

What Changed

  • Convert most files to css
  • Refactor Addons to use pure css
  • Convert base tokens and light mode tokens to pure css
  • Convert dark mode tokens to use the light dark function.

Sanity Check

  • [ ] Have you updated any usage of changed tokens?
  • Have you updated the docs with any component changes?
  • [ ] Have you updated the dependency graph with any component changes?
  • Have you run linters?
  • Have you run prettier?
  • Have you tried building the css?
  • Have you tried building storybook?
  • Do you need to update the package version?

Sorry, something went wrong.

@Jeremy-Walton Jeremy-Walton added Breaking Change This will cause problems so be sure to indicate that in the release notes Base Tokens Changes to the base tokens labels Jan 31, 2025
@Jeremy-Walton Jeremy-Walton self-assigned this Jan 31, 2025
Copy link

linear bot commented Jan 31, 2025

CCC-47 @mixin Tokens

@Jeremy-Walton Jeremy-Walton merged commit bbb6c36 into main Jan 31, 2025
1 check passed
@Jeremy-Walton Jeremy-Walton deleted the ccc-47-mixin-tokens branch January 31, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Base Tokens Changes to the base tokens Breaking Change This will cause problems so be sure to indicate that in the release notes
Development

Successfully merging this pull request may close these issues.

None yet

2 participants