Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCC-50] No Build #266

Merged
merged 13 commits into from
Jan 31, 2025
Merged

[CCC-50] No Build #266

merged 13 commits into from
Jan 31, 2025

Conversation

Jeremy-Walton
Copy link
Member

Why?

To finalize the move towards the optics no-build using pure css, we needed to remove all of the references to scss and sass along with changing the build process to cut out the scss middle man. Along the way, we found some minor documentation and styling errors that needed to be addressed.

What Changed

  • Fix source links
  • Remove all references and uses of sass
  • Fix missed class references and styling (btn-primary, padding, etc.)
  • Update new component instructions
  • Remove all references and uses of scss
  • Create build scripts for css compiling

Sanity Check

  • [ ] Have you updated any usage of changed tokens?
  • Have you updated the docs with any component changes?
  • [ ] Have you updated the dependency graph with any component changes?
  • Have you run linters?
  • Have you run prettier?
  • Have you tried building the css?
  • Have you tried building storybook?
  • Do you need to update the package version?

@Jeremy-Walton Jeremy-Walton added bug Something isn't working Breaking Change This will cause problems so be sure to indicate that in the release notes Simplification labels Jan 31, 2025
@Jeremy-Walton Jeremy-Walton self-assigned this Jan 31, 2025
Copy link

linear bot commented Jan 31, 2025

CCC-50 No Build

@Jeremy-Walton Jeremy-Walton merged commit 52ef292 into main Jan 31, 2025
1 check passed
@Jeremy-Walton Jeremy-Walton deleted the ccc-50-no-build branch January 31, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change This will cause problems so be sure to indicate that in the release notes bug Something isn't working Simplification
Development

Successfully merging this pull request may close these issues.

2 participants