-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Coeurs Vaillants 2] Sheet update for game launch #13326
Conversation
General: - correct indentation (code) - change sheet checkbox with drop-down PC sheet: - Rename peuple into origine. - Rename capacité into métiers. - Move don de naissance and origine down with other capacities. - Set compensation below stats. - Rename richesse into points de trésors. - Set properly hp_max and aventure_max. NPC sheet: - Set properly the scale to take the full width. - Have only one big textarea for capacités to allow copy-paste from bestiary. - Add one more field for another attack. Signed-off-by: Choco Lanoar <[email protected]>
Character Sheet Info Roll20 Internal Use only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bonjour, @ChocoLanoar!
I will need to block this until version handling is added in your sheetworkers or the attributes listed below are changed back to their original names. This is to prevent the loss of data in existing games from a sheet update. I'll keep an eye out for an update, so tag me here once this is applied and I'll work to get it approved as soon as possible.
Nora
<input type="number" name="attr_pvAggr" class='sheet-inpnum2c' style="width:40px;" value='0'/> | ||
</div> | ||
<div class="sheet-libel1" style="width:10px; vertical-align: bottom;">/</div> | ||
<input type="number" name="attr_pv_max" class='sheet-inpnum2c' style="width: 45px; margin-right: 20px; vertical-align: bottom" value='0' /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changing attributes like this should come with version handling to convert the data on existing sheets and prevent destruction of data for existing games
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I didn’t anticipate it. I’m looking into sheetworker stuff to add a migration script.
<div class="sheet-libel1" style="width: 5px; margin: 0px;">/</div> | ||
<input type="number" name="attr_aventureMax" class='sheet-inpnum2c' style="width: 35px; margin-right: 0px;" value='1' min="0"/> | ||
<div class="sheet-libel1" style="width: 5px; margin: 0px;">/</div> | ||
<input type="number" name="attr_aventure_max" class='sheet-inpnum2c' style="width: 35px; margin-right: 0px;" value='1' min="0"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
Add version management script to allow element name update and retrocompatibility. Signed-off-by: Choco Lanoar <[email protected]>
Submission Checklist
Required
Changes / Description
General
PC sheet
NPC sheet