Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make firebots and janibots targets of sentience events. #116

Conversation

Merrokitsune
Copy link
Collaborator

@Merrokitsune Merrokitsune commented Oct 25, 2024

About the PR

Makes firebots and janibots targets of sentience events.

Why / Balance

When you got killed, the only choices you have are either immobile vending machines mostly locked away in departments from crew, pests that can't speak and get killed often, and station pets that are very often locked up in their respective departments (and can't speak), all unable to make meaningful interactions (and in turn, roleplay). Imagine, being a minor bot, not only becoming a spare 'silicon', but getting to actually help people. Does that sound fun to you?

Technical details

Media

Screenshot from 2024-10-26 00-54-24
Screenshot from 2024-10-26 21-37-58

Requirements

Breaking changes

Changelog

🆑

  • tweak: Firebots and Janibots can become targets of sentience events.

@github-actions github-actions bot added the Changes: No C# changes: Might require no knowledge of C#. label Oct 25, 2024
@Merrokitsune Merrokitsune added the S: Needs Discussion Status: Anyone can discuss and contribute to what the PR should be. label Oct 25, 2024
@GitHubUser53123
Copy link
Collaborator

have you tested whenever they have respective functionality under player's control

@Merrokitsune Merrokitsune added the S: Frozen Status: This PR can't be merged, because of a current freeze. label Oct 26, 2024
@Merrokitsune
Copy link
Collaborator Author

Frozen, due to update.

@Merrokitsune
Copy link
Collaborator Author

Unfrozen.

@Merrokitsune Merrokitsune reopened this Oct 26, 2024
@Merrokitsune Merrokitsune removed the S: Frozen Status: This PR can't be merged, because of a current freeze. label Oct 26, 2024
@Merrokitsune
Copy link
Collaborator Author

have you tested whenever they have respective functionality under player's control

Yes, I have.
And they seemed to work.
Janibots can clean, and firebots can spray. They can also seem to speak.
Screenshot from 2024-10-26 21-37-58

@Merrokitsune Merrokitsune added the S: Undergoing maintainer discussion Status: This PR is undergoing discussion with maintainers on what to do with it. label Oct 26, 2024
@GitHubUser53123 GitHubUser53123 merged commit e585f11 into RonRonstation:master Oct 26, 2024
11 checks passed
@Merrokitsune Merrokitsune deleted the Make-minor-bots-capable-of-sentience- branch October 30, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# changes: Might require no knowledge of C#. S: Needs Discussion Status: Anyone can discuss and contribute to what the PR should be. S: Undergoing maintainer discussion Status: This PR is undergoing discussion with maintainers on what to do with it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants