Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redid Base.yml while allowing slimepeople to not rot. #9

Merged
merged 11 commits into from
Mar 29, 2024
Merged

Redid Base.yml while allowing slimepeople to not rot. #9

merged 11 commits into from
Mar 29, 2024

Conversation

Merrokitsune
Copy link
Collaborator

About the PR

Slimepeople rot now, which is disappointing. This aims to revert that change. I also redid Base.yml to move the "perishable" component to species files.

Why / Balance

Slimepeople used to not rot, which is the only major advantage slimes have over other races. Now that slimes rot, that advantage has been lost, and Slimepeople became worse. This aims to bring that advantage back.

Technical details

moved the "- type: Perishable" stuff from the Base.yml to the species. This allows only certain species with that type to rot.

Diona do not need the "- type: Perishable" component, because they disintegrate upon dying, which makes rotting irrelevant.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • tweak: Slimepeople now have no - type: perishable which means they don’t rot anymore.
  • tweak: Dionae also have no - type: perishable, but they disintegrate upon dying, which makes rotting pointless.
  • tweak: Redid Base.yml

@github-actions github-actions bot added the Changes: No C# changes: Might require no knowledge of C#. label Mar 27, 2024
@Merrokitsune Merrokitsune changed the title Patch 1 Redid Base.yml while allowing slime people to not rot. Mar 27, 2024
@Merrokitsune Merrokitsune changed the title Redid Base.yml while allowing slime people to not rot. Redid Base.yml while allowing slimepeople to not rot. Mar 27, 2024
@Merrokitsune
Copy link
Collaborator Author

Alright, test first before committing.
I am not sure if this will work or not. I got 2 errors.
I hope it works.

@RonRonstation RonRonstation merged commit 271f0b9 into RonRonstation:master Mar 29, 2024
9 of 11 checks passed
@Merrokitsune Merrokitsune deleted the patch-1 branch March 29, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# changes: Might require no knowledge of C#.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants