task: Update routes #131
Merged
task: Update routes #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/UserTest.php
Outdated
|
|
||
| $response->assertNotFound(); | ||
|
|
||
| $response->assertJson(['error' => 'The route v0.1/users/test could not be found.']); |
There was a problem hiding this comment.
it is not necessary to check the default error messages
Suggested change
| $response->assertJson(['error' => 'The route v0.1/users/test could not be found.']); |
tests/UserTest.php
Outdated
| $this->assertEqualsFixture('get_user', $response->json()); | ||
| } | ||
|
|
||
| public function testGetWrongUrl() |
There was a problem hiding this comment.
What happens if delete does not have wereNumber(id)?
Please add tests for delete and put also
Suggested change
| public function testGetWrongUrl() | |
| public function testGetIdParamAsString() |
DenTray
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
whereNumber('id')validation to all routes with id path parameters to enforce numeric-only values.