[203]: add model relations property annotations #208
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds model relations property annotations to Laravel models by generating @property annotations for relationships. The implementation adds support for both single and collection-based relationships with appropriate type hints.
- Adds
@propertyannotations for model relationships in generated models - Imports
Illuminate\Database\Eloquent\Collectionwhen collection-type relations are present - Generates proper type hints for singular (
Model|null) and plural (Collection|Model) relationships
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| stubs/model.blade.php | Adds conditional import for Collection class when collection-type relations exist |
| src/Generators/ModelGenerator.php | Implements logic to generate relation annotations and determine Collection import necessity |
| tests/fixtures/ModelGeneratorTest/*.php | Test fixtures showing expected output with relation property annotations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| foreach ($relations as $relation) { | ||
| $relation = class_basename($relation); | ||
|
|
||
| $result[$this->getRelationName($relation, $type)] = $this->getRelationType($relation, $type); |
There was a problem hiding this comment.
The method getRelationName() is being called but is not defined in this class. This will cause a fatal error when the code is executed.
Copilot uses AI. Check for mistakes.
| protected function getRelationType(string $relation, string $type): string | ||
| { | ||
| if (in_array($type, self::PLURAL_NUMBER_REQUIRED)) { | ||
| return "Collection|$relation"; |
There was a problem hiding this comment.
| return "Collection|$relation"; | |
| return "Collection<{$relation}>"; |
| $relation = class_basename($relation); | ||
|
|
||
| $result[$this->getRelationName($relation, $type)] = $this->getRelationType($relation, $type); |
There was a problem hiding this comment.
let's try to refactor it to prevent code duplication (the same logic already exists in the prepareRelations)
2 participants
refs: #203