[55] fix admin name question option #75
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 19160147855Details
💛 - Coveralls |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the createAdminUser method to improve code clarity and consistency by extracting the service admin check into a dedicated boolean variable. The logic remains functionally equivalent but becomes more readable and maintainable.
Key Changes:
- Introduced
$isServiceAdminboolean variable to consolidate the service admin check - Updated all conditional expressions to use the new variable instead of redundant checks
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DenTray
reviewed
Nov 3, 2025
src/Commands/InitCommand.php
Outdated
|
|
||
| if ($this->authType === AuthTypeEnum::None) { | ||
| $adminCredentials['name'] = $this->ask("Please enter admin name{$serviceLabel}", "{$serviceName} Admin"); | ||
| $adminCredentials['name'] = $this->ask("Please enter admin name{$serviceLabel}", when($isServiceAdmin, "{$serviceName} Admin", 'Admin')); |
Collaborator
There was a problem hiding this comment.
let's move default name generation to the separate variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #55