Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: LineParameters alternative constructors #122

Open
5 of 7 tasks
benoit9126 opened this issue Aug 25, 2023 · 0 comments
Open
5 of 7 tasks

ENH: LineParameters alternative constructors #122

benoit9126 opened this issue Aug 25, 2023 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@benoit9126
Copy link
Member

benoit9126 commented Aug 25, 2023

In #121, I realized several things that should be done regarding the LineParameters class. Here is a small list of remaining tasks

  • In the class method from_geometry, there is a geometric configuration for a twisted line and for an underground line. There is no configuration for overhead line (flag configuration for example). Currently, the overhead is linked to the twisted configuration.
  • In the class method from_geometry, some checks should be done:
    • with an underground line, the height parameter should be negative. For overhead and twisted lines, height should be positive
    • when the sections become large, there is some geometric infeasibility because of the d_{ext}/4 constraint (especially in the twisted configuration) => Maybe modify the provided lengths/dimensions to ensure that no impossible configurations can be generated.
  • In the class method from_geometry, if no neutral data are provided, maybe consider generating configuration without neutral wire (3x3 matrices). Or take a new "phases" argument to define the number of conductors in the geometric configuration.
  • The class method from_name_mv uses the Coiffier's coefficients to generate the impedance and shunt admittance matrices. It needs to be refactor in a more interesting name. The documentation doesn't exist...
  • The class method from_name_lv is a wrapper around the from_geometry class method with default values. I think it should be removed.
@benoit9126 benoit9126 added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 25, 2023
@benoit9126 benoit9126 self-assigned this Aug 25, 2023
@benoit9126 benoit9126 assigned alihamdan and unassigned benoit9126 Nov 17, 2023
alihamdan added a commit that referenced this issue Nov 17, 2023
This is part of #122. We deprecate this method now so that we can remove it
completely in a later release.
alihamdan added a commit that referenced this issue Nov 17, 2023
This is part of #122. We deprecate this method now so that we can remove
it completely in a later release.
alihamdan added a commit that referenced this issue Jan 23, 2024
Resolves #161
Fixes some of the points of #122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants