Add lines catalogue and get_catalogue method #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoit9126
approved these changes
Jan 22, 2024
|
@benoit9126 I removed Coiffier's model and kept only IEC as discussed yesterday. I also added some missing IEC data for conductor type "AM" which are derived from (but not equal to) aluminum lines according to the standard. This should unblock our pre release. I kept the |
benoit9126
approved these changes
Jan 23, 2024
I'll merge this so that you can start working on building a wheel and send another PR with all missing changelog entries (not only changes made here) |
|
👍 I let you write the changelog and I will manage all the other remaining things related to the release |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #161
Fixes some of the points of #122