Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON serialization, flexible parameters, and lines #4

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

alihamdan
Copy link
Member

  • Fixes in JSON serialization:
    • Add missing max_loading for lines
    • Add missing max_loading for transformers
    • Add missing tap for transformers
    • Fix error due to sorting of line parameters and transformer parameters with heterogeneous ID types
  • Fix TypeError in Line.max_current
  • Fix use of FlexibleParameters from roseau-load-flow instead of the single-phase equivalent
  • Disallow single-phase transformers. Only single-phase equivalent of three-phase transformers are allowed for balanced three-phase networks
  • Improve the switch checks messages to print the actual reason of the failure.

@alihamdan alihamdan added the bug Something isn't working label Dec 2, 2024
@alihamdan alihamdan requested a review from Saelyos December 2, 2024 09:03
@alihamdan alihamdan self-assigned this Dec 2, 2024
@alihamdan alihamdan changed the title Fix JSON serialization, flexible parameters, adn lines Fix JSON serialization, flexible parameters, and lines Dec 2, 2024
Copy link
Collaborator

@Saelyos Saelyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes, looks good to me

@alihamdan alihamdan merged commit 1a610a7 into develop Dec 2, 2024
5 checks passed
@alihamdan alihamdan deleted the fix-bugs branch December 2, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants