Fix macos tests #274
Merged
Fix macos tests #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.9 was the last version to support python 2
lyskov
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Looks good to me, - thank you for catching this @nikitalita !
ldedier-gpfw
pushed a commit
to G-P-S/binder
that referenced
this pull request
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macos tests have been failing for quite a while now but weren't being detected.
pybind 11 2.10 removed python 2 support, and since pybind11 got updated to >= 2.10 in homebrew, all the python 2 tests have been failing. The script didn't actually exit with an error code if the tests failed though, so it wasn't being detected.
Additonally, tests are failing to build at all on macos 13 due to differences in the header file layouts; if we don't include the C header files AFTER the C++ header files, binder will fail to find c std header files (e.g.
<cstdargs>->stdargs.h). I have modified tests/CMakeLists.txt to fix this.