Fix Python finding #275
Merged
Fix Python finding #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyskov
approved these changes
Nov 17, 2023
ldedier-gpfw
pushed a commit
to G-P-S/binder
that referenced
this pull request
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
FindPython3.cmakehad a bug in which it failed to find simplified python exes, likepython3.Additionally, it was not very good at dealing with systems that had numerous python installations to choose from, like my own;
cmake>= 3.19 hasFindPython3, and all the other cmake Modules that you currently have. So, I changed Cmakelists.txt to only include the modules if the cmake version is < 3.19.