Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate metadata from IPFS to Bundlr + Arweave #66

Merged
merged 3 commits into from
Jul 24, 2022
Merged

feat: migrate metadata from IPFS to Bundlr + Arweave #66

merged 3 commits into from
Jul 24, 2022

Conversation

0xGabi
Copy link
Member

@0xGabi 0xGabi commented Jul 23, 2022

No description provided.

@0xGabi 0xGabi added the 🏗 enhancement New feature or request label Jul 23, 2022
@0xGabi 0xGabi requested a review from PJColombo July 23, 2022 06:07
@vercel
Copy link

vercel bot commented Jul 23, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
rosette-app ✅ Ready (Inspect) Visit Preview Jul 24, 2022 at 4:03PM (UTC)

@0xGabi 0xGabi changed the title [DRAFT] feat: migrate metadata from IPFS to Bundler + Arweave [DRAFT] feat: migrate metadata from IPFS to Bundlr + Arweave Jul 23, 2022
@0xGabi 0xGabi changed the title [DRAFT] feat: migrate metadata from IPFS to Bundlr + Arweave feat: migrate metadata from IPFS to Bundlr + Arweave Jul 24, 2022
@PJColombo
Copy link
Member

PJColombo commented Jul 24, 2022 •
edited
Loading

This bundlr integration is looking lit 🔥.

Amazing job @0xGabi.

I would migrate this logic to the rosette-core package and publish a new version with it that we can use on the client instead. This way we can remove the redundant subgraph/metadata-fetching logic we have at the moment (#47)

@0xGabi 0xGabi merged commit 123d4d3 into staging Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PJColombo PJColombo PJColombo approved these changes

Assignees
No one assigned
Labels
🏗 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xGabi @PJColombo