Allow the "custom emote" field to support emotes with the [](#emote) format #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…such as /r/gravityfalls (Not global yet)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds experimental support for emotes from subreddits like /r/gravityfalls to be added in as a custom subreddit. It adds the following:
[](#emote)format to be added as custom subreddits[](#emote)emotes aren’t converted by default (to allow for people to use alttext without an emote visible)This Pull Request has the following known bugs:
[](#emote)emotes don’t support global emote conversion, as it’s too buggy at the moment io include (fixing the regex has the issue of the hash/slash of the emote being visible as alt-text)[](#su-emote)format (because of the dash).The following is untested at the moment:
[](#emote)is added in as a “core” emote (bundled with BPM).I will try to fix most of the bugs over time, how long that will take. Feel free to wait to merge until this fork is mature enough.