-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality for fallback emotes within Reddit #50
Open
Ebreium
wants to merge
14
commits into
Rothera:master
Choose a base branch
from
Anthony-Ceres:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bringing forks into synchronization.
Synchronize forks.
Merge fixes of indentation inconsistencies in bpm-reddit.js
Changed attribute naming to be consistent with the rest of BPM.
Could these be squashed? Also, your editor seems to have put tabs in. |
To be honest, this repo has no real code style guidelines, so I doubt it matters. Worse case, someone can add a commit converting everything into spaces. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the ability to add a fallback emote on Reddit to increase compatibility for those without BPM.
This is done by entering a second emote as a modifier, which the BPM client then uses instead of the parent emote while a browser without BPM will render only the parent.
So
[](/twibeam-/ktwicute)
will render as twibeam for those without BPM, and ktwicute for those with the extension.As the slash designates a modifier to be an emote, any other modifiers before or after the second emote are preserved, meaning
[](/twibeam-i-/ktwicute-r)
will appear as an inverted and reversed ktwicute for BPM users.The click-toggle function was also changed in order to cycle through the full emote with all modifiers, the full text, and how a user without BPM would see the emote.
Example:
Uses:
Allowing users who wish to have only a BPM emote present in the body of their comment able to do so while not appearing as a blankpost. For instance this is one such comment that could be fixed with something like
[](/twisad-/sadlyra)
.General smoothing of emote usage from more innate integration with default emotes. Here is a comment made by Faranight using the feature on the main sub mainly to test, but it illustrates this nicely.
Short RPs that often compromise variety for accessibility, such as most posts on /r/emotestories.
This was a joint effort by Faranight, ByzantineFailure, and myself.