Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions for mdx eslint and html checker #27

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

kjhahjdhjkadsf
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented May 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2023 2:17pm

@denverbaumgartner
Copy link
Contributor

@kjhahjdhjkadsf thanks for your efforts so far on these actions, we are really excited to get these integrated into the repository. when it comes to html-proofer, it appears like all the tests are not properly reporting back the correct status. for example, on this run it is falsely reporting back failed links that are indeed correct. here are some examples:

1, External link https://github.com/RubiconDeFi/docs/tree/master/pages/guides/swap.zh.mdx failed: got a time out (response code 0) (status code 0)
2. External link https://optimistic.etherscan.io/tokens failed (status code 403)
3. External link https://github.com/RubiconDeFi/docs/tree/master/pages/guides/trade/adding-a-trading-pair.hi.mdx failed: got a time out (response code 301) (status code 301)

i will continue to review the logs of the actions and report back with any other errors i observe. please let me know if I can be of any help in resolving the issue outlined above.

@denverbaumgartner
Copy link
Contributor

eslint action appears to be working as expected 🚀

@denverbaumgartner
Copy link
Contributor

hi @kjhahjdhjkadsf, thanks for the update to the html-checker. unfortunately, this does not appear to have resolved the problem we are experiencing with reported external links being broken when they are in fact working. here are some examples:

  1. External link https://crates.io/crates/rubi failed (status code 404)
  2. External link https://github.com/RubiconDeFi/docs/tree/master/pages/index.mdx failed with something very wrong. It's possible libcurl couldn't connect to the server, or perhaps the request timed out. Sometimes, making too many requests at once also breaks things. (status code 0)
  3. External link https://metamask.io/download.html failed (status code 404)

I was able to replicate this behavior on both a seperate pull request to this repository and within the logs of the github actions of your forked repository. the logs are too large to attach here, but i have found pulling them down locally to inspect is easier than parsing them on the browser.

let me know if i can be of any help, if i had to guess the error messaging reported in example 2 above is probably the source of the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants