Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployments: relevant addresses #52 #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

denverbaumgartner
Copy link
Contributor

adds the protocol fee recipient to the deployments page. also opens #63 as a next step to improve the styling of the documentation.

@vercel
Copy link

vercel bot commented Aug 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Aug 8, 2023 8:05pm

@forrestnorwood
Copy link
Contributor

You should pull master in here so you can also include the Base recipient address.

Copy link
Contributor

@forrestnorwood forrestnorwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fee recipient addresses can be queried from the chain and I think they're out of place on Deployments with our smart contract addresses.

I do want to include your changes to the API page though, so let's scrap the recipient addresses for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants