Link against libopenblas.lib on Windows #24
Conversation
Without a respective lib, linking would inevitably fail. We also add a check for cblas.h, and if either is not found, disable ext/tensor with a respective warning. See also <RubixML#22>.
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
There was a problem hiding this comment.
Hey @cmb69 thanks so much for the help! Unfortunately, this file gets overwritten by the Zephir compiler so we need to add this logic to this build script for example https://github.com/RubixML/Tensor/blob/master/build-ext. Let me know if you would like to make the changes, otherwise I think I can probably do it.
Thank you again! Won't you join our group on Telegram? https://t.me/RubixML
P.S. Is this something we should bring up to the Zephir team?
|
Ah, I see! I wouldn't know, though, how to adapt the build script. If you can do it, please go ahead. :) |
|
Hey @cmb69, I haven't been able to find the documentation to get an understanding of this or anything in the config.w32 file. From what I gather so far, it's Javascript with GNU Automake macros. However, the closest docs I found are here https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.70/autoconf.html#index-AC_005fCHECK_005fLIB but the macro signatures are different. Can you explain what exactly is going on here? Also, is it necessary to compile on Windows or is it just a convenience? Apologize for my ignorance but again, this file is supposed to be handled by the Zephir compiler and I have been relying on it so far to give us the correct configuration. Thank you! |
Without a respective lib, linking would inevitably fail. We also add
a check for cblas.h, and if either is not found, disable ext/tensor
with a respective warning.
See also #22.