Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Issue #1294 #1355

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

campbelle2
Copy link

This is the code we had when the code auto-completion began, but we are not sure why. If you figure it out or need us to change anything just let us know

@bnmnetp
Copy link
Member

bnmnetp commented Aug 3, 2022

I looks like there are a few pieces missing? I don't see where you have defined the keywords?

@campbelle2
Copy link
Author

campbelle2 commented Aug 3, 2022

I see what you mean @bnmnetp . The file with the keywords is in the node_modules directory but I cannot view that directory on GitHib. Could it be something with that folder not appearing properly?

@bnmnetp
Copy link
Member

bnmnetp commented Aug 3, 2022

I think you need to add it locally and push to github.

@campbelle2
Copy link
Author

None of the changes I make in the node_modules folder appear in the source control tab of VS code so I cannot commit them. Do I need to do something specific to commit changes from that folder?

@bnmnetp
Copy link
Member

bnmnetp commented Aug 3, 2022

The node_modules folder is ignored. Those are all installed automatically based on the contents of the package.json file when you run npm install. In other words, those are third party libraries that you should not be modifying.

If you added files then you can move them to activecode/js and import them there. If you modified other files I would be curious to know which ones.... There should be a way to do this without modifying third party libraries directly.

@campbelle2
Copy link
Author

All of the other modes/keyword banks for the CodeMirror autocompletion were in that folder so I assumed this one needed to be as well. The current import for the java mode in activecode.js is codemirror/mode/java so that may need to be changed if the java.js file needs to be outside node_modules.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants