This repository has been archived by the owner on Jun 7, 2023. It is now read-only.
Micro Parsons: Render blocks raw when all blocks are html in non-html problems #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnmnetp
reviewed
May 15, 2023
| @@ -80,6 +81,22 @@ export default class HParsons extends RunestoneBase { | |||
| this.originalBlocks = this.processSingleContent(code, '--blocks--').split('\n').slice(1,-1); | |||
| this.hiddenSuffix = this.processSingleContent(code, '--hiddensuffix--'); | |||
| this.unittest = this.processSingleContent(code, '--unittest--'); | |||
| // (for pretext) if all blocks can be parsed as html but language is not html, | |||
| // ask micro parsons to render raw | |||
| if (this.language != 'html') { | |||
There was a problem hiding this comment.
I don't understand the logic of checking for not html. I think you should check for language == 'natural' or 'math'. Those are the cases where we want the html formatting to show through. Other languages should be verbatim as you have it I think. @rbeezer correct me if I'm wrong.
|
Yes, an author's source should specify "natural" language, or a computer language. (There might be a default for authors, perhaps for historical reasons.) But in any event, the generated HTML for the problem should have an explicit attribute to that effect which the code here can react to unambiguously. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RunestoneInteractive/rs#20
Render blocks raw when micro Parsons find all blocks contain HTML, and when the language is not html.
Reason for asking all blocks to contain HTML:
a complete HTML can be used as a string in other languages, e.g. in Python,
re.match('<b>', '<b>content</b>')Two examples are shown below (included in test).
micro-Parsons dependency is updated in this PR, so
npm installis needed.