This repository has been archived by the owner on Jun 7, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 225
More config values for Runcstone components #867
Open
vasiljevic
wants to merge
11
commits into
RunestoneInteractive:master
Choose a base branch
from
Petlja:nm/V2CompatibilityUpdate
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0b1a55a
added config for compare button
nenadmilutinovic ad5bb1d
updated docstrings for MChoice and FillInTheBlank
vasiljevic ae91929
changed deprecated chrome_options to options and fitb multiplechoice…
maric993 7ab3f18
new updateconfig directive and tests
maric993 5d8ae5d
added .vs to git
maric993 750ef5a
made updateConfig available only in test dirs
maric993 789815e
Code review fixes
maric993 90d33ed
follow up fixes
maric993 203de5d
added doc for update config
maric993 eed1f01
Merge branch 'master' into nm/V2CompatibilityUpdate
maric993 ac5b251
quick fix
maric993 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,6 +48,7 @@ build_info | |
|
||
# IDEs | ||
.vscode/ | ||
.vs/ | ||
**/sphinx-enki-info.txt | ||
# Mac stuff | ||
.DS_Store |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -297,3 +297,7 @@ htmlhelp_basename = 'PythonCoursewareProjectdoc' | |
#shortanswer_optional_div_class = 'journal alert alert-success' | ||
#showeval_div_class = 'runestone explainer alert alert-warning' | ||
#tabbed_div_class = 'alert alert-warning' | ||
#mchoice_compare_button_show - if False, hide the 'Compare me' button (default True) | ||
#mchoice_compare_button_show = True | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add a brief description of what this option controls for both of these. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In fitb.py and multiplechoice.py there are these two comments:
Should I add these to conf.tmpl as well? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, exactly. |
||
#fitb_compare_button_show - if False, hide the 'Compare me' button (default True) | ||
#fitb_compare_button_show = True |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
|
||
from .update import * |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,119 @@ | ||
============================== | ||
Testing update-config direcive | ||
============================== | ||
|
||
|
||
Multiple Choice | ||
--------------- | ||
|
||
.. mchoice:: question1 | ||
:multiple_answers: | ||
:correct: a,b,d | ||
:answer_a: red | ||
:answer_b: yellow | ||
:answer_c: black | ||
:answer_d: green | ||
:feedback_a: Red is a definitely on of the colors. | ||
:feedback_b: Yes, yellow is correct. | ||
:feedback_c: Remember the acronym...ROY G BIV. B stands for blue. | ||
:feedback_d: Yes, green is one of the colors. | ||
|
||
Which colors might be found in a rainbow? (choose all that are correct) | ||
|
||
|
||
|
||
|
||
|
||
Fill in the Blank | ||
----------------- | ||
.. fillintheblank:: fill1 | ||
|
||
Fill in the blanks to make the following sentence: "The red car drove away." | ||
|
||
The |blank| car drove |blank|. | ||
|
||
- :red: Correct. | ||
:x: Incorrect. Try 'red'. | ||
- :away: Correct. | ||
:x: Incorrect. Try 'away'. | ||
|
||
|
||
|
||
|
||
.. update-config:: | ||
:set_config_option: mchoice_compare_button_show False | ||
.. update-config:: | ||
:set_config_option: fitb_compare_button_show False | ||
|
||
|
||
Multiple Choice | ||
--------------- | ||
|
||
.. mchoice:: question2 | ||
:multiple_answers: | ||
:correct: a,b,d | ||
:answer_a: red | ||
:answer_b: yellow | ||
:answer_c: black | ||
:answer_d: green | ||
:feedback_a: Red is a definitely on of the colors. | ||
:feedback_b: Yes, yellow is correct. | ||
:feedback_c: Remember the acronym...ROY G BIV. B stands for blue. | ||
:feedback_d: Yes, green is one of the colors. | ||
|
||
Which colors might be found in a rainbow? (choose all that are correct) | ||
|
||
|
||
|
||
Fill in the Blank | ||
----------------- | ||
.. fillintheblank:: fill2 | ||
|
||
Fill in the blanks to make the following sentence: "The red car drove away." | ||
|
||
The |blank| car drove |blank|. | ||
|
||
- :red: Correct. | ||
:x: Incorrect. Try 'red'. | ||
- :away: Correct. | ||
:x: Incorrect. Try 'away'. | ||
|
||
|
||
.. update-config:: | ||
:set_config_option: mchoice_compare_button_show True | ||
|
||
|
||
Multiple Choice | ||
--------------- | ||
|
||
.. mchoice:: question3 | ||
:multiple_answers: | ||
:correct: a,b,d | ||
:answer_a: red | ||
:answer_b: yellow | ||
:answer_c: black | ||
:answer_d: green | ||
:feedback_a: Red is a definitely on of the colors. | ||
:feedback_b: Yes, yellow is correct. | ||
:feedback_c: Remember the acronym...ROY G BIV. B stands for blue. | ||
:feedback_d: Yes, green is one of the colors. | ||
|
||
|
||
.. update-config:: | ||
:set_config_option: fitb_compare_button_show True | ||
|
||
Fill in the Blank | ||
----------------- | ||
.. fillintheblank:: fill3 | ||
|
||
Fill in the blanks to make the following sentence: "The red car drove away." | ||
|
||
The |blank| car drove |blank|. | ||
|
||
- :red: Correct. | ||
:x: Incorrect. Try 'red'. | ||
- :away: Correct. | ||
:x: Incorrect. Try 'away'. | ||
|
||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is duplicated -- see line 78.