Issue192 Emojis in Usernames #443
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
There was an issue to keep users from adding emoji's inside their usernames when registering a new account.
Fix:
To resolve this issue, We added a new test to search usernames for emoji unicode using regex. This username test was added at the validation layer which will affect new users registering for courses initially and existing users registering for a new course. The issue requested to find a graceful way to phase out emoji's in usernames and this is the best solution we could think of.
Test:
To test this issue, attempt to register for a new course with an emoji in the username, there should be an error message saying "username: Username cannot contain emojis"
fix #192